Skip to content

Support APK built with AGP version 8.3#28

Merged
devunwired merged 1 commit into
devunwired:masterfrom
mathroule:support-agp-8.3
May 3, 2024
Merged

Support APK built with AGP version 8.3#28
devunwired merged 1 commit into
devunwired:masterfrom
mathroule:support-agp-8.3

Conversation

@mathroule

@mathroule mathroule commented Apr 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Context

When parsing an APK built with AGP version 8.3, APK Resource Toolkit raise an error:

undefined method 'key' for nil:NilClass

      return "@#{res_spec.id}/#{entry.values[0].key}"
                                               ^^^^
/vendor/bundle/ruby/3.1.0/gems/apktools-0.7.4/lib/apktools/apkresources.rb:250:in 'get_resource_key'
/vendor/bundle/ruby/3.1.0/gems/apktools-0.7.4/lib/apktools/apkxml.rb:241:in 'parse_xml'

This issues does not happen when parsing an APK built with AGP version 8.2.2.

Changes

  • Check if entry values is not empty

@mathroule mathroule changed the title Check for empty entry values Support APK built with AGP version 8.3 Apr 11, 2024
@mathroule
Check for empty entry values
f5632e8 
Fix an issue with AGP version 8.3
@devunwired devunwired merged commit 185769c into devunwired:master May 3, 2024
@devunwired

devunwired commented May 3, 2024

Copy link
Copy Markdown
Owner

Thanks for your contribution! As you might have noticed, I don't maintain this codebase much anymore. However, I'll see if I can find some time in the next few days to publish a new gem version with this update.

@mathroule mathroule deleted the support-agp-8.3 branch May 4, 2024 19:36
@mathroule mathroule restored the support-agp-8.3 branch May 4, 2024 20:08
@WoLewicki WoLewicki mentioned this pull request Aug 29, 2024
Merged
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathroule @devunwired